Repository navigation
mkconcore: reject spaces in node and edge names with a clear message - #710
Open
yadavchiragg wants to merge 1 commit into
Open
yadavchiragg wants to merge 1 commit into
yadavchiragg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #709
A node or edge name containing a space was accepted, but the generated build script is unquoted, so it split the name into separate directories and failed (cp: target 'ctrl/a.py': No such file or directory) while mkconcore and ./build both exited 0.
safe_name() now also rejects spaces for node/edge names and tells the user to use '_' instead. Directory paths are unaffected, and no sample workflow in the repo uses spaces in names.
Added tests/test_mkconcore_name_spaces.py: node and edge names with spaces are rejected with the hint (fail without the change); names without spaces and an output directory with spaces still build.